fix(concurrency): replace score::cpp::expected with score::Result - #577
Open
shegazyy wants to merge 2 commits into
Open
fix(concurrency): replace score::cpp::expected with score::Result#577shegazyy wants to merge 2 commits into
shegazyy wants to merge 2 commits into
Conversation
shegazyy
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 1, 2026 13:49
shegazyy
requested a deployment
to
workflow-approval
September 1, 2026 13:49 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
September 1, 2026 13:49 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
shegazyy
requested a deployment
to
workflow-approval
September 1, 2026 14:06 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
September 1, 2026 14:06 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
suggested changes
Sep 1, 2026
danth
left a comment
danth
left a comment
Member
There was a problem hiding this comment.
ResultBlank is deprecated, please use Result<void> instead 😄
shegazyy
requested a deployment
to
workflow-approval
September 6, 2026 12:51 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
September 6, 2026 12:51 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
|
Documentation preview for this pull request is available at: |
shegazyy
added a commit
to Valeo-S-CORE-Organization/lifecycle
that referenced
this pull request
Sep 7, 2026
…ResultBlank score::ResultBlank is deprecated in score_baselibs in favor of the equivalent score::Result<void>. Replace all usages across the concurrency queue headers and their unit test. Addresses review comment from @danth on PR eclipse-score#577.
shegazyy
force-pushed
the
fix/use-score-result-in-concurrency-338
branch
from
September 7, 2026 11:25
c71ea6b to
9b81490
Compare
shegazyy
requested a deployment
to
workflow-approval
September 7, 2026 11:25 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
shegazyy
requested a deployment
to
workflow-approval
September 7, 2026 11:25 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
…lipse-score#338) Migrate launch_manager concurrency types to score::Result / score::ResultBlank as tracked in issue eclipse-score#338. Changes: - concurrency_error_domain.hpp: change ConcurrencyErrc underlying type from std::uint8_t to score::result::ErrorCode; add ConcurrencyErrorDomain class, kConcurrencyErrorDomain singleton, and ADL MakeError() function; add ostream operator<< and optional log stream operator<< - mpmc_concurrent_queue.hpp: replace all score::cpp::expected_blank<ConcurrencyErrc> with score::ResultBlank; replace score::cpp::expected<T, ConcurrencyErrc> with score::Result<T>; replace score::cpp::make_unexpected() with score::MakeUnexpected() - mpsc_bounded_queue.hpp: same score::ResultBlank / score::MakeUnexpected substitutions as mpmc; remove now-unused #include <score/expected.hpp> - BUILD: add @score_baselibs//score/result dep to mpmc_concurrent_queue and mpsc_bounded_queue targets Callers (thread_pool.hpp, graph.cpp, component_event_queue.hpp) use .error() == ConcurrencyErrc::kX comparisons which still work because score::result::Error has an implicit constructor from any registered error enum via ADL MakeError(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
score::ResultBlank is deprecated in score_baselibs in favor of the equivalent score::Result<void>. Replace all usages across the concurrency queue headers and their unit test. Addresses review comment from @danth on PR eclipse-score#577. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
shegazyy
force-pushed
the
fix/use-score-result-in-concurrency-338
branch
from
September 7, 2026 11:57
9b81490 to
9769cb2
Compare
Contributor
Author
|
Hello @danth changes applied and merged with latest main. Ready for review whenever you have the time. |
NicolasFussberger
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate launch_manager concurrency types to score::Result / score::ResultBlank as tracked in issue #338.
Changes:
with score::ResultBlank; replace score::cpp::expected<T, ConcurrencyErrc> with score::Result; replace score::cpp::make_unexpected() with score::MakeUnexpected()
Callers (thread_pool.hpp, graph.cpp, component_event_queue.hpp) use .error() == ConcurrencyErrc::kX comparisons which still work because score::result::Error has an implicit constructor from any registered error enum via ADL MakeError().