Skip to content

Changing ready condition reqs - #467

Open
MaciejKaszynski wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:ready-conditions-reqs
Open

Changing ready condition reqs#467
MaciejKaszynski wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:ready-conditions-reqs

Conversation

@MaciejKaszynski

Copy link
Copy Markdown
Contributor

Altering requirements in accordance to discussion on https://github.com/orgs/eclipse-score/discussions/2386#discussioncomment-17494192

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 16456a75-9b19-480e-8b26-9be425bcb2ed
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (46 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2073 targets configured)

Analyzing: target //:license-check (155 packages loaded, 6238 targets configured)

Analyzing: target //:license-check (160 packages loaded, 6259 targets configured)

Analyzing: target //:license-check (166 packages loaded, 6352 targets configured)

Analyzing: target //:license-check (171 packages loaded, 11421 targets configured)

Analyzing: target //:license-check (172 packages loaded, 11429 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
[8 / 15] [Prepa] Writing repo mapping manifest for //:license.check.license_check
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 29.879s, Critical Path: 0.28s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
@github-actions

Copy link
Copy Markdown
Contributor

The created documentation from the pull request is available at: docu-html

@danth danth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for the requirement titles.

Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/docs/requirements/requirements.rst Outdated
Comment thread score/launch_manager/src/daemon/src/process_group_manager/details/transition.hpp Outdated
MaciejKaszynski and others added 6 commits August 27, 2026 14:40
Co-authored-by: Daniel Thwaites <danth@danth.me>
Signed-off-by: Maciej Kaszynski <161459353+MaciejKaszynski@users.noreply.github.com>

@SimonKozik SimonKozik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks OK

@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval August 28, 2026 07:47 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski deployed to workflow-approval August 28, 2026 07:47 — with GitHub Actions Active
shall be met before the component is considered to have reached its
:term:`Ready State`.

.. comp_req:: Condition timeout

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need a requirement regarding the timeout for reaching the Ready State?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants