Skip to content

refactor: remove unused explicit source metadata #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximilianSoerenPollak merged 1 commit into from
Sep 15, 2026
Merged

refactor: remove unused explicit source metadata #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions bzl/bundle_rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ DocsBundleInfo = provider(
"entries": "Ordered entries, one per source directory, including its final documentation-tree location.",
"own_source_files": "This bundle's direct source files, excluding nested bundles.",
"source_dir_execroot_path": "Execution-root-relative path of this bundle's direct source root.",
"own_source_is_explicit": "Whether the direct sources came from explicit source targets.",
"sourcelinks": "Source-code-link JSON files together with their owning repository.",
"external_runfiles": "Documentation source files not read from the workspace at runtime.",
# Bundle-owned supporting/runtime files. Unlike host-owned docs data,
Expand Down Expand Up @@ -282,7 +281,6 @@ def _docs_bundle_impl(ctx):
entries = []
own_source_files = []
source_dir_execroot_path = ""
own_source_is_explicit = False
own_external_runfiles = []
own_data = depset(direct = ctx.files.data)

Expand Down Expand Up @@ -324,7 +322,6 @@ def _docs_bundle_impl(ctx):
# undeclared siblings from the shared parent directory.
runtime_path = _source_targets_runtime_path(ctx.files.source_targets)
source_dir_execroot_path = _convert_runtime_path_to_execroot_path(runtime_path)
own_source_is_explicit = True
source_files = _source_targets_relative_paths(
ctx.files.source_targets,
runtime_path,
Expand Down Expand Up @@ -410,7 +407,6 @@ def _docs_bundle_impl(ctx):
entries = entries,
own_source_files = depset(direct = own_source_files),
source_dir_execroot_path = source_dir_execroot_path,
own_source_is_explicit = own_source_is_explicit,
sourcelinks = sourcelinks,
external_runfiles = external_runfiles,
data = all_data,
Expand Down
Loading