Skip to content

refactor: expose bundle source paths in execroot form - #824

Open
AlexanderLanin wants to merge 1 commit into
runtime-path-conversionfrom
source-root-execroot
Open

AlexanderLanin wants to merge 1 commit into
runtime-path-conversionfrom
source-root-execroot

Conversation

@AlexanderLanin

@AlexanderLanin AlexanderLanin commented Sep 14, 2026

Copy link
Copy Markdown
Member

What this achieves

Passes an execution-root-relative source path from bundle analysis directly to Needs generation.

Why this is needed

Bundle analysis already knows both the runtime and execution-root spellings. Keeping the execution-root path in the provider makes that contract explicit and removes duplicate path conversion from the Needs rule.

Changes

  • Rename the provider field own_source_root to source_dir_execroot_path.
  • Compute the execution-root path once in the bundle rule and reuse it for the manifest and provider.
  • Make needs_rules.bzl consume the provider path directly.

@AlexanderLanin
AlexanderLanin added this pull request to stack #821 September 14, 2026 18:44
@AlexanderLanin AlexanderLanin changed the title source root execroot refactor: expose bundle source paths in execroot form Sep 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-824: https://eclipse-score.github.io/docs-as-code/pr-824/

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having these stacked PR'' s makes this much easier to review I gotta admit.

Although coudl also be because these changes are small in themselfs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants