refactor: clarify runtime to execroot path conversion - #823
Merged
Merged
Conversation
AlexanderLanin
added this pull request to stack #821
September 14, 2026 18:30
AlexanderLanin
requested review from
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
September 14, 2026 18:30
AlexanderLanin
changed the title
Contributor
|
Documentation preview for this pull request is available at: |
MaximilianSoerenPollak
previously approved these changes
Sep 15, 2026
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
This seems fine to me.
As long as we are sure that bundle_execroot_path is the only thing used in these places that should exists.
AlexanderLanin
dismissed
MaximilianSoerenPollak’s stale review
September 15, 2026 13:15
The merge-base changed after approval.
MaximilianSoerenPollak
force-pushed
the
runtime-path-conversion
branch
from
September 15, 2026 13:15
d954ea3 to
618d8b5
Compare
MaximilianSoerenPollak
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this achieves
Clarifies the helper name used when translating bundle runtime paths to paths relative to Bazel's execution root.
Why this is needed
The helper is used for both local and external bundle source paths. Its previous name,
_bundle_execroot_path, did not describe the input transformation clearly, which made the path representation boundary harder to understand.Changes
_bundle_execroot_pathto_convert_runtime_path_to_execroot_path.