Skip to content

chore(bazel): align development-only dependencies #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eclipse-score-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(bazel): align development-only dependencies #818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ pip.parse(
use_repo(pip, "docs_as_code_hub_env")

# Additional Python rules provided by aspect, e.g. an improved version of
bazel_dep(name = "aspect_rules_py", version = "1.4.0")
bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
bazel_dep(name = "aspect_rules_py", version = "1.4.0", dev_dependency = True)

@a-zw a-zw Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it adapt aspect_rules_py? The description only mentions buildifier_prebuilt.

@MaximilianSoerenPollak MaximilianSoerenPollak Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not touch aspect_rules_py.

I think that is wrong, as there is another policy that deletes the dev_dependency or sets it to False as far as I know.

@AlexanderLanin I'm remembering right, right?

bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2", dev_dependency = True)

# PlantUML for docs
bazel_dep(name = "rules_java", version = "8.15.1")
Expand Down
Loading