Fix typed proxy access to GenericSkeleton event storage#557
Closed
Tejveerpratap2803 wants to merge 1 commit into
Closed
Fix typed proxy access to GenericSkeleton event storage#557Tejveerpratap2803 wants to merge 1 commit into
Tejveerpratap2803 wants to merge 1 commit into
Conversation
Tejveerpratap2803
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
Tejveerpratap2803
force-pushed
the
tepr_fix_generic_skeleton_access
branch
from
c6b902d to
dbfa8ec
Compare
Tejveerpratap2803
force-pushed
the
tepr_fix_generic_skeleton_access
branch
2 times, most recently
from
9a75ecd to
6217745
Compare
Typed ProxyEvent now accesses event samples through EventMetaInfo raw slot storage instead of interpreting provider storage as EventDataStorage<SampleType>. This keeps typed proxies compatible with GenericSkeleton-created storage while preserving typed skeleton behavior. Proxy event tests and fixtures were updated to emulate production typed storage with a type-erased EventMetaInfo view. Existing proxy event construction tests were aligned with the fixture sample type so EventMetaInfo validation matches the dummy provider storage.
LittleHuba
force-pushed
the
tepr_fix_generic_skeleton_access
branch
from
6217745 to
82a1b13
Compare
Contributor
|
Is this still required now that #394 was fixed in place? |
Contributor
Author
Actually, I have addressed the comments that Brendan provided in Rudresh's system PR. Since that PR has already been merged, I will close this one. |
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#311