test: improve generic skeleton interaction tests for CI stability#513
Merged
LittleHuba merged 1 commit intoJun 22, 2026
Conversation
ShoroukRamzy
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
Contributor
Author
|
Hi @crimson11, Could you please have a look when you have time? Thanks! |
ShoroukRamzy
force-pushed
the
generic-skeleton-test-improvement
branch
from
651561d to
bf65f83
Compare
castler
previously approved these changes
Jun 20, 2026
| std::cout << "[PROVIDER] Finished initial 5s sleep." << std::endl; | ||
|
|
||
| for (int i = 0; i < kSamplesToProcess; ++i) | ||
| uint64_t i = 0; |
Contributor
There was a problem hiding this comment.
For future: Please use std::uint64_t
| mode = argv[++i]; | ||
| score::mw::com::runtime::InitializeRuntime(score::mw::com::runtime::RuntimeConfiguration(argc, argv)); | ||
|
|
||
| score::cpp::stop_source stop_source; |
Contributor
There was a problem hiding this comment.
For future, please always use {}-Initalization
Contributor
|
@ShoroukRamzy can you maybe fix the suggestions as you have to rebase because of a merge conflict anyhow? |
ShoroukRamzy
force-pushed
the
generic-skeleton-test-improvement
branch
2 times, most recently
from
e9521ea to
c31d40a
Compare
Contributor
Author
Hi @castler, Done |
- Marked all integration tests with @pytest.mark.xfail due to a known Generic Skeleton memory alignment/base pointer bug. This allows the CI to pass until the underlying fix is implemented in a follow-up PR.
ShoroukRamzy
force-pushed
the
generic-skeleton-test-improvement
branch
from
c31d40a to
1799c14
Compare
LittleHuba
approved these changes
Jun 22, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective: Improve the stability and reliability of the generic_skeleton integration tests in CI environments.
Changes:
Test Flow Redesign: The provider now loops infinitely (handling SIGTERM via stop_token for graceful shutdown) while the consumer strictly verifies 30 consecutive samples starting from the first one it successfully receives.
Orchestration: The Python test runner now waits purely for the consumer to succeed and exit, and then cleanly terminates the provider. This completely eliminates random test hangs/failures caused by thread scheduling delays on GitHub Actions.
XFAIL: All tests are currently marked as "expected to fail" (xfail) to prevent CI blockage. They successfully run but correctly catch a known Generic Skeleton base pointer / memory alignment bug. Once the underlying C++ bug is fixed in a subsequent PR, the xfail markers will be removed in a follow-up PR