Skip to content

Clean Code for debug/org.eclipse.debug.terminal#2691

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/debug/org.eclipse.debug.terminal
Jun 2, 2026
Merged

Clean Code for debug/org.eclipse.debug.terminal#2691
akurtakov merged 2 commits into
masterfrom
clean-code/debug/org.eclipse.debug.terminal

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.terminal/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 8b6c593dd05a479a5ac075100298b1c721f32ea0 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Tue, 2 Jun 2026 06:38:02 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/debug/org.eclipse.debug.terminal/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.terminal/META-INF/MANIFEST.MF
index 8297d835c6..94f238fadc 100644
--- a/debug/org.eclipse.debug.terminal/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.terminal/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.terminal;singleton:=true
 Bundle-Vendor: %providerName
-Bundle-Version: 1.0.200.qualifier
+Bundle-Version: 1.0.300.qualifier
 Import-Package: org.eclipse.terminal.connector;version="[1.0.0,2.0.0)",
  org.eclipse.terminal.control;version="[1.0.0,2.0.0)"
 Require-Bundle: org.eclipse.core.runtime,
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Test Results

    54 files  ±0      54 suites  ±0   36m 28s ⏱️ - 1m 30s
 4 667 tests ±0   4 645 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 895 runs  ±0  11 742 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 38f0e76. ± Comparison against base commit 451fc6c.

@akurtakov akurtakov merged commit 771d533 into master Jun 2, 2026
18 checks passed
@akurtakov akurtakov deleted the clean-code/debug/org.eclipse.debug.terminal branch June 2, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants