Use a solid color for unselected tabs - #4275
Open
vogella wants to merge 2 commits into
Open
Conversation
The themes declared two identical gradient stops, which left CTabFolder.gradientColors set and made the folder paint the controls in its tab row with a rendered background image instead of a plain color. The themes now use a single color, the CSS handler collapses a flat gradient to the solid path, and the unused *_UNSELECTED_TABS_COLOR_END definitions are removed. Fixes eclipse-platform#4274
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
BeckerWdf
reviewed
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The themes declared two identical gradient stops for
swt-unselected-tabs-color, which leftCTabFolder.gradientColorsset and made the folder paint the controls in its tab row (min/max bar, chevron, topRight composite) with a rendered background image instead of a plain color. On GTK that image is not painted on a ToolBar, so those bars can fall back to the GTK theme color.The themes now declare a single color, the CSS handler collapses a flat gradient to the solid path so custom themes get the same benefit, and the unused
*_UNSELECTED_TABS_COLOR_ENDdefinitions are removed. No visual change in the shipped themes: all stops were identical or differed by one unit.Fixes #4274