Drop unused PropertyHelper and its self-test#4049
Merged
akurtakov merged 1 commit intoJun 2, 2026
Merged
Conversation
Contributor
Test Results 861 files + 19 861 suites +19 52m 12s ⏱️ + 21m 22s Results for commit b815b58. ± Comparison against base commit bd473bb. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
PropertyHelper provided a reflective bean-property reader using java.beans.Introspector. Nothing in the platform tree calls it; its only consumer was TestPropertyHelper, a unit test that exercised the helper itself. Delete the helper and the orphaned test in one pass. Contributes to eclipse-platform#3980
vogella
force-pushed
the
css-drop-propertyhelper
branch
from
cfa039f to
b815b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertyHelper(org.eclipse.e4.ui.css.swt.helpers) provided a reflective bean-property reader built onjava.beans.Introspector. It was added in 2010 (bug 315649) to drop thecommons-beanutilsdependency, withSWTElementas its only caller. Bug 268249 deleted thatSWTElementlater the same month, and nothing has referenced the helper since, so it has been dead code for roughly 16 years. Its only remaining consumer wasTestPropertyHelper, a unit test exercising the helper against itself.This removes both the helper and the orphaned test. Pure deletion, no API surface change (bundle is
x-friendsonly).Contributes to #3980