Skip to content

Fix empty page tree in pre-filtered preference dialog #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vogella wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −4
Open

Fix empty page tree in pre-filtered preference dialog #4044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...ipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/FilteredPreferenceDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ protected Text doCreateFilterText(Composite parent) {

@Override
public void setInitialText(String text) {
if (filterText != null && !filterText.isDisposed()) {
filterText.setMessage(text != null ? text : ""); //$NON-NLS-1$
}
// No placeholder hint; the search icon already signals the field's purpose.
// initialText is still tracked for the empty-filter check and accessible name.
initialText = text != null ? text : ""; //$NON-NLS-1$
}

/**
Expand All @@ -140,7 +140,8 @@ protected void addFilter(ViewerFilter filter) {
getViewer().addFilter(filter);

if (filterText != null) {
setFilterText(WorkbenchMessages.FilteredTree_FilterMessage);
Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this removal make other places using that NLS obsolete or maybe kind of incompatible, such as ... ?

eclipse.platform.ui/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/FilteredTree.java

Line 619 in a6ae91c

|| previousFilterText.equals(WorkbenchMessages.FilteredTree_FilterMessage)

// Keep the field empty so the viewer filter narrows the pages; the
// hint text would otherwise be applied as a pattern and hide all pages.
textChanged();
}

Expand Down
Loading