Migrate OpenProjectExplorerFolderTest to JUnit 5#4008
Conversation
|
Hi @claude — thank you for your contribution! The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:
To resolve this, please:
Once done, push a new commit (or rebase) to re-trigger the ECA validation. If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk. Thanks again for your contribution! |
vogella
force-pushed
the
migrate-openprojectexplorerfolder-junit5
branch
from
28643b4 to
bbd078b
Compare
akurtakov
force-pushed
the
migrate-openprojectexplorerfolder-junit5
branch
from
bbd078b to
6ee9a3b
Compare
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Is there a specific reason to not migrate to PerformanceTestCaseJunit5 and reimplement the contents of that class? In that case we shouldn't do that decision locally but align all implementations of PerformanceTestCaseJunit5 accordingly.
Looked at this class (again), it makes sense to use it. I will update PR |
Migrate the JUnit 4 PerformanceTestCaseJunit4 base class to its JUnit 5 counterpart PerformanceTestCaseJunit5, which manages the PerformanceMeter via @BeforeEach/@AfterEach.
vogella
force-pushed
the
migrate-openprojectexplorerfolder-junit5
branch
from
6ee9a3b to
2e57f14
Compare
|
The class has been updated to use PerformanceTestCaseJunit5 |
2 participants
Migrate this performance test from JUnit 4 to JUnit 5. The test now extends
PerformanceTestCaseJunit5(the JUnit 5 counterpart of the droppedPerformanceTestCaseJunit4), which manages thePerformanceMetervia@BeforeEach/@AfterEach. Reusing the shared base class keeps the meter handling consistent with all other performance tests instead of reimplementing it locally.