Skip to content

Migrate ProblemsViewPerformanceTest to JUnit 5#4007

Merged
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:migrate-problemsview-junit5
Jun 2, 2026
Merged

Migrate ProblemsViewPerformanceTest to JUnit 5#4007
vogella merged 1 commit into
eclipse-platform:masterfrom
vogella:migrate-problemsview-junit5

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented May 15, 2026

Migrate this performance test from JUnit 4 to JUnit 5. The test now extends PerformanceTestCaseJunit5 (the JUnit 5 counterpart of the dropped PerformanceTestCaseJunit4), which manages the PerformanceMeter via @BeforeEach/@AfterEach, and CloseTestWindowsRule is replaced with CloseTestWindowsExtension. Reusing the shared base class keeps the meter handling consistent with all other performance tests instead of reimplementing it locally.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Test Results

   861 files  ±0     861 suites  ±0   50m 46s ⏱️ - 1m 25s
 8 024 tests ±0   7 781 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 511 runs  ±0  19 856 ✅ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit 916be38. ± Comparison against base commit bacf493.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the migrate-problemsview-junit5 branch from d492698 to 83d3b3a Compare May 31, 2026 12:28
Migrate the JUnit 4 PerformanceTestCaseJunit4 base class to its JUnit 5
counterpart PerformanceTestCaseJunit5, which manages the
PerformanceMeter via @BeforeEach/@AfterEach, and replace
CloseTestWindowsRule with CloseTestWindowsExtension.
@HeikoKlare HeikoKlare force-pushed the migrate-problemsview-junit5 branch from 83d3b3a to 916be38 Compare June 2, 2026 10:34
@vogella vogella merged commit 6481ecf into eclipse-platform:master Jun 2, 2026
18 checks passed
@vogella vogella deleted the migrate-problemsview-junit5 branch June 2, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant