[Win32] Partially revert unnecessary creation of GC operations#3351
Closed
HeikoKlare wants to merge 1 commit into
Closed
[Win32] Partially revert unnecessary creation of GC operations#3351HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
The GC's `getClipping()` operation stores region handles representing the clipping region (potentially at different zooms) that is combined with the passed region object. The handles for that passed region object are created on demand, so that immediate disposal of the clipping region handle leads to failures when creating the handle for the passed region later on. This change reverts c6bf2e9 that introduced the immediate disposal of GC operations to avoid that the clipping handles are not available.
Contributor
Contributor
Author
|
Closing this as superceded by: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent enhancement to avoid the unnecessary creation of GC operations
introduced a regression, which particularly manifests in broken rendering of CTabFolders. For an example in the Manifest editor, see the screenshots below.
The GC's
getClipping()operation stores region handles representing the clipping region (potentially at different zooms) that is combined with the passed region object. The handles for that passed region object are created lazy, so that the clipping region handle needs to be stored until that point in time. Otherwise it will leads to failures when lazily creating the handle for the passed region later on. To avoid that the clipping handles are not available, this change reverts c6bf2e9 that introduced the immediate disposal of GC operations.This is meant to be a temporary revert until a proper solution for the handling of clipping regions inside the GC is found.
Without this change:
With this change:
