Skip to content

[Win32] Remove dead Windows CE/Mobile constants from OS.java#3349

Open
HeikoKlare wants to merge 1 commit into
eclipse-platform:masterfrom
HeikoKlare:remove-dead-ce-constants
Open

[Win32] Remove dead Windows CE/Mobile constants from OS.java#3349
HeikoKlare wants to merge 1 commit into
eclipse-platform:masterfrom
HeikoKlare:remove-dead-ce-constants

Conversation

@HeikoKlare
Copy link
Copy Markdown
Contributor

Summary

  • Removes three constants from OS.java that are vestiges of Windows CE / Windows Mobile support, which was dropped long ago
  • NM_RECOGNIZEGESTURE — Windows CE gesture notification; particularly confusing because it shares its numeric value (NM_FIRST - 16) with the still-used NM_RELEASEDCAPTURE
  • SPI_SETSIPINFO — Pocket PC Soft Input Panel control
  • WS_EX_CAPTIONOKBTN — Windows Mobile caption OK button extended style

None of the three constants is referenced anywhere in the SWT codebase (confirmed by full-repo search). The change is Java-only and requires no native rebuild.

🤖 Generated with Claude Code

SPI_SETSIPINFO (Pocket PC Soft Input Panel), NM_RECOGNIZEGESTURE
(Windows CE gesture notification, a confusing duplicate of
NM_RELEASEDCAPTURE), and WS_EX_CAPTIONOKBTN (Windows Mobile caption
OK button) are vestiges of CE/Mobile support that was dropped long ago.
None of the three constants is referenced anywhere in the SWT codebase.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

Test Results (win32)

   30 files  ±0     30 suites  ±0   4m 28s ⏱️ -3s
4 698 tests ±0  4 623 ✅ ±0  75 💤 ±0  0 ❌ ±0 
1 228 runs  ±0  1 204 ✅ ±0  24 💤 ±0  0 ❌ ±0 

Results for commit c7aaf79. ± Comparison against base commit 81da08f.

@HeikoKlare HeikoKlare marked this pull request as ready for review June 1, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant