[Win32] Fix swapped arguments in readRegistryDwords null checks#3348
Open
HeikoKlare wants to merge 1 commit into
Open
[Win32] Fix swapped arguments in readRegistryDwords null checks#3348HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
Objects.requireNonNull(T obj, String message) takes the object to check as the first argument. The two calls in readRegistryDwords had the arguments reversed, causing the non-null string literals "key" and "valueName" to be checked instead of the actual key and valueName variables, making both null guards complete no-ops. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Objects.requireNonNull(T obj, String message)takes the object to check as the first argument and the error message as the second.OS.readRegistryDwords, both calls had the arguments reversed: the non-null string literals"key"and"valueName"were being checked instead of the actualkeyandvalueNamevariables.nullkey or valueName would pass through silently and cause aNullPointerExceptionor unexpected behaviour later.🤖 Generated with Claude Code