Skip to content

Move JSVGRasterizer unit test to SVG fragment#3347

Open
HeikoKlare wants to merge 1 commit into
eclipse-platform:masterfrom
HeikoKlare:jsvgrasterizer-test
Open

Move JSVGRasterizer unit test to SVG fragment#3347
HeikoKlare wants to merge 1 commit into
eclipse-platform:masterfrom
HeikoKlare:jsvgrasterizer-test

Conversation

@HeikoKlare
Copy link
Copy Markdown
Contributor

The JSVGRasterizerTest is currently implemented in the ordinary SWT test bundle, even though the JSVGRasterizer is only one possible (and the current default) SVGRasterizer implementation. The test is actually a unit test for the provider, thus it is properly placed in the SVG fragment that provides the rasterizer implementation itself.

This change moves the test class to the SVG fragment and enables it via pure surefire execution. This is similar to what is already done regarding execution of OS-specific unit tests in the OS fragments.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF
bundles/org.eclipse.swt.svg/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 5151e6ef4a5c8e4b43d1606eb6e75cac5f8de527 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sun, 31 May 2026 11:17:09 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF b/bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF
index 880ac15225..f51e06d1b8 100644
--- a/bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.swt.svg
-Bundle-Version: 3.133.0.qualifier
+Bundle-Version: 3.133.100.qualifier
 Automatic-Module-Name: org.eclipse.swt.svg
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
diff --git a/bundles/org.eclipse.swt.svg/pom.xml b/bundles/org.eclipse.swt.svg/pom.xml
index 97f5be0222..ae49855a0b 100644
--- a/bundles/org.eclipse.swt.svg/pom.xml
+++ b/bundles/org.eclipse.swt.svg/pom.xml
@@ -19,7 +19,7 @@
 		<relativePath>../../</relativePath>
 	</parent>
 	<artifactId>org.eclipse.swt.svg</artifactId>
-	<version>3.133.0-SNAPSHOT</version>
+	<version>3.133.100-SNAPSHOT</version>
 	<packaging>eclipse-plugin</packaging>
 
 	<build>
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2026

Test Results

  188 files  +6    188 suites  +6   28m 3s ⏱️ + 1m 52s
4 729 tests ±0  4 706 ✅ ±0   23 💤 ±0  0 ❌ ±0 
6 848 runs  ±0  6 685 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit 75e6393. ± Comparison against base commit df2c1a1.

This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both.
org.eclipse.swt.tests.junit.JSVGRasterizerTest ‑ testRasterizeWithTargetSize
org.eclipse.swt.tests.junit.JSVGRasterizerTest ‑ testRasterizeWithTargetSizeHavingInvalidHeight
org.eclipse.swt.tests.junit.JSVGRasterizerTest ‑ testRasterizeWithTargetSizeHavingInvalidWidth
org.eclipse.swt.tests.junit.JSVGRasterizerTest ‑ testRasterizeWithTargetSizeWithInvalidSVG
org.eclipse.swt.tests.junit.JSVGRasterizerTest ‑ testRasterizeWithZoom
org.eclipse.swt.tests.junit.JSVGRasterizerTest ‑ testRasterizeWithZoomNegative
org.eclipse.swt.tests.junit.JSVGRasterizerTest ‑ testRasterizeWithZoomWithInvalidSVG
org.eclipse.swt.svg.JSVGRasterizerTest ‑ testRasterizeWithTargetSize
org.eclipse.swt.svg.JSVGRasterizerTest ‑ testRasterizeWithTargetSizeHavingInvalidHeight
org.eclipse.swt.svg.JSVGRasterizerTest ‑ testRasterizeWithTargetSizeHavingInvalidWidth
org.eclipse.swt.svg.JSVGRasterizerTest ‑ testRasterizeWithTargetSizeWithInvalidSVG
org.eclipse.swt.svg.JSVGRasterizerTest ‑ testRasterizeWithZoom
org.eclipse.swt.svg.JSVGRasterizerTest ‑ testRasterizeWithZoomNegative
org.eclipse.swt.svg.JSVGRasterizerTest ‑ testRasterizeWithZoomWithInvalidSVG

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the jsvgrasterizer-test branch from 098b102 to 8ae5b24 Compare May 31, 2026 15:50
The JSVGRasterizerTest is currently implemented in the ordinary SWT test
bundle, even though the JSVGRasterizer is only one possible (and the
current default) SVGRasterizer implementation. The test is actually a
unit test for the provider, thus it is properly placed in the SVG
fragment that provides the rasterizer implementation itself.

This change moves the test class to the SVG fragment and enables it via
pure surefire execution. This is similar to what is already done
regarding execution of OS-specific unit tests in the OS fragments.
@HeikoKlare HeikoKlare force-pushed the jsvgrasterizer-test branch from 8ae5b24 to 75e6393 Compare June 1, 2026 13:30
@HeikoKlare HeikoKlare marked this pull request as ready for review June 1, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants