Skip to content

ci: declare workflow-level contents: read on maven, pr-checks, version-increments#3322

Open
arpitjain099 wants to merge 1 commit into
eclipse-platform:masterfrom
arpitjain099:chore/declare-workflow-perms
Open

ci: declare workflow-level contents: read on maven, pr-checks, version-increments#3322
arpitjain099 wants to merge 1 commit into
eclipse-platform:masterfrom
arpitjain099:chore/declare-workflow-perms

Conversation

@arpitjain099
Copy link
Copy Markdown

Adds workflow-level permissions: contents: read to three workflows that just run build / checks: maven, pr-checks, version-increments. No GitHub API writes.

Same post-CVE-2025-30066 (tj-actions/changed-files) hardening pattern. YAML validated locally.

@arpitjain099 arpitjain099 force-pushed the chore/declare-workflow-perms branch from 97786d7 to a97ce40 Compare May 26, 2026 06:32
…n-increments

Three workflows that just run build/checks. No GitHub API writes from the workflows. contents: read at workflow level is appropriate.

Post-CVE-2025-30066 hardening pattern. yaml.safe_load validated.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@akurtakov akurtakov force-pushed the chore/declare-workflow-perms branch from a97ce40 to 0653041 Compare May 30, 2026 09:30
@akurtakov akurtakov requested a review from HannesWell May 30, 2026 09:30
@akurtakov
Copy link
Copy Markdown
Member

akurtakov commented Jun 1, 2026

There is smth wrong with this PR:

Invalid workflow file: .github/workflows/pr-checks.yml#L16
The workflow is not valid. .github/workflows/pr-checks.yml (Line: 16, Col: 3): Error calling workflow 'eclipse-platform/eclipse.platform.releng.aggregator/.github/workflows/verifyFreezePeriod.yml@master'. The workflow is requesting 'issues: read', but is only allowed 'issues: none'.

from https://github.com/eclipse-platform/eclipse.platform.swt/actions/runs/26680432597

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Test Results

  182 files  + 2    182 suites  +2   27m 42s ⏱️ + 1m 43s
4 724 tests ± 0  4 701 ✅ + 1   23 💤 ±0  0 ❌  - 1 
6 818 runs  +36  6 655 ✅ +35  163 💤 +2  0 ❌  - 1 

Results for commit 0653041. ± Comparison against base commit 3bde9ff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants