StyledText treats shortcuts incorrectly with Japanese keyboard layout #3306#3307
Open
tmssngr wants to merge 1 commit into
Open
StyledText treats shortcuts incorrectly with Japanese keyboard layout #3306#3307tmssngr wants to merge 1 commit into
tmssngr wants to merge 1 commit into
Conversation
Contributor
|
Is this a problem only on on macOS 14? That's out of date now. Is it a problem on 15.7.x and 26.x? |
Contributor
Contributor
Author
|
No, this problem is reproducible with MacOS 26.5, too. I have not tried on other systems though. Are these failing Windows tests caused by this PR? |
…clipse-platform#3306 On MacOS 14 with "Japanese Kana" keyboard pressing Cmd+A results in event.keycode == 12385 while event.character == 'a'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MacOS 14 with "Japanese Kana" keyboard pressing Cmd+A results in event.keycode == 12385 while event.character == 'a'.
This PR fixes the problem for me.