Add app-driven limit alarm state APIs - #1838
Merged
kevinherron merged 1 commit intoAug 12, 2026
Merged
Conversation
Allow applications to apply already-computed exclusive and non-exclusive limit states without bypassing Milo's Condition transition machinery. Preserve the selected non-exclusive state across snapshots and maintain effective transition timing for modeled limit changes.
kevinherron
marked this pull request as ready for review
August 7, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit alarms work well when Milo evaluates a single numeric value, but the API is awkward for applications that have already calculated the alarm state themselves. Exclusive callers must redundantly provide both Active and a limit state, while non-exclusive callers cannot atomically provide the complete active set and choose which state controls the message, display name, and severity. Writing the individual nodes directly bypasses Milo's Condition transition rules.
This PR adds direct state APIs for both alarm types. Applications can provide an exclusive state, or a complete non-exclusive state set with an explicitly selected effective state. Milo still owns validation, locking, acknowledgements, timestamps, shelving, Retain, snapshots, and event generation, so each application-driven update remains one coherent Condition transition.
What changed
ExclusiveLimitAlarm.setLimitState(...), wherenulldeactivates the alarm.NonExclusiveLimitAlarm.setLimitStates(...)andgetEffectiveLimitState().ActiveState.EffectiveTransitionTimefor modeled limit-state changes.Existing
evaluate(double)behavior remains unchanged for applications that want Milo's standard scalar limit evaluation.