fix(release): make publish path recoverable and its verification real - #8
Merged
Conversation
…real - Stop --dry-run writing the stamped version to disk: only the publish honoured the flag, so a dry run desynchronised every manifest from the lockfile and the next install asked the registry for a version that had never been published - Skip a package whose dist-tag already points at the version, so a PARTIAL publish can be re-run: the packages that succeeded otherwise reject the retry, and the version cannot be advanced without a commit because it is derived from the commit count rather than stored - Verify against the dist-tag endpoint rather than the package document, with backoff; npm view reads a CDN that caches NEGATIVE responses, and the bootstrap queries every name while it does not exist, so the check failed on precisely the first publish it exists to guard - Read dist-tag output as TEXT: the subcommand accepts --json and ignores it, so JSON.parse threw and every caller failed open - Keep stdio fully inherited; capturing stderr to read npm's rejection prevents the interactive one-time-password prompt Verified against the live registry with all ten versions already published: ten skips, then the verification passed. Fixes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified against the live registry with all ten versions already published: ten skips, then the verification passed.
Fixes #7