ci: check the Theia versions our peer range promises - #11
Merged
Conversation
The three Theia packages publish a `^1.71.0` peer range while CI installs only 1.75.0, so most of the range we promise adopters is untested. Legs - Run the declared floor and latest weekly, plus any version or dist-tag on demand, with fail-fast off so one leg's red cannot cancel the other - Typecheck and unit-test the framework packages only: no bundler and no e2e, which is where moving Theia drags Electron, React and Node with it Mechanism - Pin every @theia/* found across the workspace manifests into the root overrides, then discard the tree; with the lockfile in place npm never re-resolves those edges and the install silently keeps its versions - Carry a min-version table, because @theia/bundle-plugin published nothing before 1.72.0 and a blanket rewrite 404s the whole install - Assert every installed @theia/core copy matches, since a partially applied override reads as success from the hoisted path alone - Pin npm from packageManager, because 10.9.2 crashes in arborist here Verified by running each step's own body rather than a retyping of it. - The floor is TRUE: tsc -b, three typecheck:test and 179 tests pass at 1.71.0, and again at 1.75.0 - Control on the assertion: the lockfile-present install succeeds and the assertion rejects it, naming the copy that stayed behind - Zero copies fails too, which a mismatch-only check would have passed - Whether the inputs context is simply unpopulated under schedule is reasoned from the docs, not measured; the first cron run settles it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three Theia packages publish a
^1.71.0peer range while CI installs only 1.75.0, so most of the range we promise adopters is untested.Legs
Mechanism
Verified by running each step's own body rather than a retyping of it.