Repository navigation
feat!: run the DPS TCK and accept a pull /started without dataAddress - #28
Merged
Merged
Conversation
Add an end-to-end test that runs the data plane verification tests of the Data Plane Signaling TCK (eclipsedataspacetck/dps-tck-runtime 1.3.3) against the SDK, behind the build tag "tck", with a CI job and a "make test-tck" target. The TCK sends a consumer-pull /started with only a messageId, which the SDK rejected with 400. The specification lists dataAddress as optional for this message, so Started now accepts it; a dataAddress on a push /started is still rejected. BREAKING CHANGE: a started handler can see a nil SourceDataAddress on a pull data flow. A handler that needs the address must check for it, e.g. by returning an error that wraps ErrInvalidInput (answered with 400), as the pull samples now do. Co-Authored-By: Claude <noreply@anthropic.com>
jimmarino
self-requested a review
November 10, 2026 13:46
jimmarino
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an end-to-end test that runs the data plane tests of the DPS TCK against the SDK, like the Rust and Java SDKs do. All 23 tests pass.
internal/tests/tck(build tagtck): starts the SDK with the in-memory store and runseclipsedataspacetck/dps-tck-runtime:1.3.3via testcontainers. HTTP profile tests are excluded.tck,make test-tck, README line.Startedaccepts a consumer-pull/startedwithoutdataAddress. The TCK sends only amessageIdthere and the specification listsdataAddressas optional. AdataAddresson a push/startedis still rejected with 400.Breaking (Go API only): a started handler can see a nil
SourceDataAddresson a pull data flow.🤖 Generated with Claude Code