Skip to content

feat!: run the DPS TCK and accept a pull /started without dataAddress - #28

Merged
paullatzelsperger merged 1 commit into
mainfrom
feat/tck-e2e
Nov 10, 2026
Merged

paullatzelsperger merged 1 commit into
mainfrom
feat/tck-e2e

Conversation

@paullatzelsperger

Copy link
Copy Markdown
Contributor

Adds an end-to-end test that runs the data plane tests of the DPS TCK against the SDK, like the Rust and Java SDKs do. All 23 tests pass.

  • internal/tests/tck (build tag tck): starts the SDK with the in-memory store and runs eclipsedataspacetck/dps-tck-runtime:1.3.3 via testcontainers. HTTP profile tests are excluded.
  • New CI job tck, make test-tck, README line.
  • Started accepts a consumer-pull /started without dataAddress. The TCK sends only a messageId there and the specification lists dataAddress as optional. A dataAddress on a push /started is still rejected with 400.
  • The pull samples now answer 400 themselves if the address is missing.

Breaking (Go API only): a started handler can see a nil SourceDataAddress on a pull data flow.

🤖 Generated with Claude Code

Add an end-to-end test that runs the data plane verification tests of
the Data Plane Signaling TCK (eclipsedataspacetck/dps-tck-runtime 1.3.3)
against the SDK, behind the build tag "tck", with a CI job and a
"make test-tck" target.

The TCK sends a consumer-pull /started with only a messageId, which the
SDK rejected with 400. The specification lists dataAddress as optional
for this message, so Started now accepts it; a dataAddress on a push
/started is still rejected.

BREAKING CHANGE: a started handler can see a nil SourceDataAddress on a
pull data flow. A handler that needs the address must check for it,
e.g. by returning an error that wraps ErrInvalidInput (answered with
400), as the pull samples now do.

Co-Authored-By: Claude <noreply@anthropic.com>
@jimmarino
jimmarino self-requested a review November 10, 2026 13:46
@paullatzelsperger
paullatzelsperger merged commit 1514e95 into main Nov 10, 2026
7 checks passed
@paullatzelsperger
paullatzelsperger deleted the feat/tck-e2e branch November 10, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants