Repository navigation
feat: add control plane and data plane registration - #24
Merged
Merged
Conversation
- registration messages (ControlPlaneRegistrationMessage, DataPlaneRegistrationMessage, AuthorizationEntry) with schema tests - ControlPlaneStore with memory and Postgres implementations; callbacks resolve the endpoint of the flow's registered control plane - PUT/DELETE /controlplanes, mounted when a store is configured; prepare and start record the calling control plane on the flow - RegisterDataPlane and DeregisterDataPlane (PUT/DELETE /dataplanes) - InMemoryTrxContext now passes the caller's context through Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The samples started their HTTP servers with ListenAndServe in a goroutine and sent the first signaling request right away, which failed with "connection refused" when the server had not bound its port yet. common.StartServer now binds synchronously and serves in the background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wolf4ood
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6 of the Data Plane Signaling v1.0 migration: registration in both directions.
ControlPlaneRegistrationMessage,DataPlaneRegistrationMessageandAuthorizationEntry(flattened{"type", ...}), validated and checked against the published schemas.authorizationis required.ControlPlaneStorewith memory and Postgres (control_plane_schema.sql) implementations. WithWithControlPlaneStore,NewHandlermountsPUT /v1/controlplanesandDELETE /v1/controlplanes/{controlPlaneId}, andNotify*callbacks go to the flow's registered control plane.WithControlPlaneIdentifier; default: the only registered control plane, to be replaced by authorization in the next PR).RegisterDataPlane/DeregisterDataPlanecallPUT /dataplanesandDELETE /dataplanes/{id}on the control plane, with the same retry rules as callbacks.memory.InMemoryTrxContextnow passes the caller's context instead ofcontext.TODO().async-start-dataplaneexample registers in both directions; short README section.Out of scope: authorization (next PR).
🤖 Generated with Claude Code