Repository navigation
feat: add control plane client and data plane callbacks - #23
Merged
Merged
Conversation
- ControlPlaneClient with an HTTP implementation for
POST /transfers/{id}/dataflow/{prepared|started|completed|errored}
and GET /transfers/{id}/agreement, retrying 5xx and network errors
with exponential backoff (RetryPolicy), typed ControlPlaneError
- NotifyPrepared, NotifyStarted, NotifyCompleted and NotifyErrored:
transition the flow, send the DataFlowStatusMessage and persist the
flow only after the control plane answers 2xx
- SuspendLocally and ResumeLocally for data-plane-initiated suspension
- WithControlPlane, WithControlPlaneResolver and WithControlPlaneClient
options; ControlPlaneResolver as the seam for registration
- async-start-dataplane example, added to the CI example runs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jimmarino
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 of the Data Plane Signaling v1.0 migration: the data plane can now call its control plane.
ControlPlaneClientwith an HTTP implementation forPOST /transfers/{id}/dataflow/{prepared|started|completed|errored}andGET /transfers/{id}/agreement(returned as raw JSON, see the doc comment). The flow id is escaped as a single path segment.NotifyPrepared,NotifyStarted,NotifyCompleted,NotifyErrored: transition the flow, send theDataFlowStatusMessage, and persist only after a 2xx. Failed callbacks leave the stored flow unchanged.RetryPolicy, default 3 attempts from 200ms); 4xx is never retried and surfaces as*ControlPlaneError.SuspendLocally/ResumeLocallyfor data-plane-initiated suspension (no callback; the spec defines none).WithControlPlane(url),WithControlPlaneResolver,WithControlPlaneClient;ControlPlaneResolveris the seam for registration (next PR).async-start-dataplaneexample (202 +NotifyStarted), added to the CI example matrix; short README section.Out of scope: registration and authorization (next PRs).
ControlPlaneIDon flows is not populated yet; the static resolver ignores it.🤖 Generated with Claude Code