Skip to content

fix: rename module path and fix Prepare/Complete error handling - #21

Merged
paullatzelsperger merged 1 commit into
mainfrom
fix/prepare-complete-errors-module-path
Nov 9, 2026
Merged

paullatzelsperger merged 1 commit into
mainfrom
fix/prepare-complete-errors-module-path

Conversation

@paullatzelsperger

@paullatzelsperger paullatzelsperger commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor
  • DataPlaneApi.Prepare: return after a validation error, so the handler no longer continues and writes a second response.
  • DataPlaneSDK.Complete: check the store error instead of err, so failed saves are no longer swallowed.
  • Rename the module to github.com/eclipse-dataplane-core/dataplane-sdk-go.
  • Bump go-chi/chi/v5.

Adds regression tests for both fixes.

🤖 Generated with Claude Code

- Rename Go module from github.com/metaform/dataplane-sdk-go to
  github.com/eclipse-dataplane-core/dataplane-sdk-go and update all imports.
- Return early from DataPlaneApi.Prepare after a validation error so the
  handler does not continue and write a second response.
- Check storeErr (not err) after saving a completed data flow in
  DataPlaneSDK.Complete so store failures are propagated.
- Add Test_Prepare_InvalidPayload and Test_DataPlaneSDK_Completed_StoreError.
- Bump github.com/go-chi/chi/v5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@paullatzelsperger
paullatzelsperger merged commit 8be17e4 into main Nov 9, 2026
5 checks passed
@paullatzelsperger
paullatzelsperger deleted the fix/prepare-complete-errors-module-path branch November 9, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants