Repository navigation
fix: rename module path and fix Prepare/Complete error handling - #21
Merged
Merged
Conversation
- Rename Go module from github.com/metaform/dataplane-sdk-go to github.com/eclipse-dataplane-core/dataplane-sdk-go and update all imports. - Return early from DataPlaneApi.Prepare after a validation error so the handler does not continue and write a second response. - Check storeErr (not err) after saving a completed data flow in DataPlaneSDK.Complete so store failures are propagated. - Add Test_Prepare_InvalidPayload and Test_DataPlaneSDK_Completed_StoreError. - Bump github.com/go-chi/chi/v5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jimmarino
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataPlaneApi.Prepare: return after a validation error, so the handler no longer continues and writes a second response.DataPlaneSDK.Complete: check the store error instead oferr, so failed saves are no longer swallowed.github.com/eclipse-dataplane-core/dataplane-sdk-go.go-chi/chi/v5.Adds regression tests for both fixes.
🤖 Generated with Claude Code