sdk: Allow 4+ digit year in xs:dateTime - #617
Open
hpoeche wants to merge 4 commits into
Open
Conversation
Previously, the deserialization required values in formates `xs:dateTime` and `xs:date` to consists of exactly four digits for the year. However, the XML Schema 1.0, which is defined as reference, allow for more digits if the leading digit is non-zero. These changes adapt the regex used for deserialization of both datatypes to also allow more than four digits for year numbers if no leading zeros are used. If only four digits are uesd, leading zeros are still allowed. Fixes eclipse-basyx#616
Member
|
What happens, if you try to cast such a year this into Python's |
Similar to handling of negative dates in eclipse-basyx#586
The `GYear` and `GYearMonth` lexical representation follows the one of the year part of `xs:dateTime`. Therefore the regex needs to be changed to prohibit leading zeros for 4+ digit year. The error handling in the `into_date()` method of both classes for years that exceed Python's `datetime.MAXYEAR` is similar to the one for negative dates (introduced in eclipse-basyx#586).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the deserialization required values in formats
xs:dateTimeandxs:dateto consists of exactly four digits for the year. However, the XML Schema 1.0, which is defined as reference, allow for more digits if the leading digit is non-zero.These changes adapt the regex used for deserialization of both datatypes to also allow more than four digits for year numbers if no leading zeros are used. If only four digits are used, leading zeros are still allowed.
Fixes #616