adapter: allow optional valueId in ValueReferencePair for JSON and XML#579
Open
paul-gerber-svg wants to merge 5 commits into
Open
adapter: allow optional valueId in ValueReferencePair for JSON and XML#579paul-gerber-svg wants to merge 5 commits into
valueId in ValueReferencePair for JSON and XML#579paul-gerber-svg wants to merge 5 commits into
Conversation
Currently, the JSON and XMOL deserializiers raise an error when parsing Blob or File submodels that do not include a contentType The contentType attribute has a cardinality of 0..1 for both classes and should therefore be optional. The implementation now aligns with this specification and defaults to None if the field is absent in the data.
Member
|
I think this depends on #572. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the JSON and XML deserializers raised a
KeyErrorif aValueReferencePairdid not contain avalueId.However, according to the IDTA specification,
valueIdis explicitly optional (cardinality 0..1).Following changes were added:
.get('valueId')to handle missing keys without crashing..find()to check if the element exists before parsing it.