model.datatypes: Improve BCE date error message#578
Merged
s-heppner merged 2 commits intoJun 19, 2026
Conversation
Previously `_parse_xsd_date()` and `_parse_xsd_datetime()` raised `ValueError("Negative Dates are not supported by Python")` when given an XSD value with a leading `-` (BCE year). This was technically false as input is not malformed, only not supported.
This change raises `NotImplementedError` instead, allowing callers to distinguish "invalid input" from "known SDK limitation.". Additionally pointing users to https://github.com/eclipse-basyx/basyx-python-sdk/issues to report the lack of implementation.
Bump copyright year to 2026
s-heppner
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #565
Previously
_parse_xsd_date()and_parse_xsd_datetime()raisedValueError("Negative Dates are not supported by Python")when given an XSD value with a leading-(BCE year). This was technically false as input is not malformed, only not supported.This change raises
NotImplementedErrorinstead, allowing callers to distinguish "invalid input" from "known SDK limitation.". Additionally pointing users to https://github.com/eclipse-basyx/basyx-python-sdk/issues to report the lack of implementation.