Repository navigation
Finisher collector: owner-bound route evidence & rollback pins (depends on #25; NOT_READY) - #47
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5837030
into
agent/certforge-security-release-20260924
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e0d592b03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| result, _ = self._observe("front", front) | ||
| self._front(front, result) |
There was a problem hiding this comment.
Restore the singleton when front-proof validation fails
If an owner probe completes the front journey, including its terminal halt, but the returned proof fails _front validation (for example, an earlier status snapshot has aged beyond the 30-second freshness limit), the exception skips _restoration entirely. The CLI then reports HELD and exits, leaving the shared singleton halted even though restoration was admitted. Make recovery independent of successful proof validation, while retaining fresh admission checks and the failed collection outcome, so an evidence-validation failure does not leave the target unavailable.
Useful? React with 👍 / 👎.
Purpose
Focused four-file Finisher observer/collector implementation. Captures an unsigned, fail-closed journey over eight agent fronts with exact owner readbacks, safe process cleanup, rollback restoration checks, documentation, and regression tests.
Dependency / base
agent/certforge-readiness-20261003, pinned base SHA424fc76fa09d9a83fcbe0d2ec12dc62ef97859c9.Exact source and scope
2e0d592b031c5482bf69f150aec74012dc953bf8.5efe62b70c08a911e2bf7ae9df3d766506215ca7— bit-for-bit match to isolated QUENCH hardening commitf5a8fbabb2ee4c70b0934a99631b631e0809c74d.docs/FINISHER_COLLECTOR.mdscripts/collect_finisher_e2e.pysrc/echo_certification_forge/finisher_collector.pytests/test_finisher_collector.pystability-frontobservations (three windows × eight fronts), exact route/provider/snapshot hash binding while permitting one shared Cloudflare singleton run ID, and exact comparison to four owner-approved immutable rollback checkpoint/config digest pins. Malformed/replayed/cross-front proofs fail closed.Checks (2026-11-08)
NOT_READY.pytest -q760 passed, 9 skipped; FORGE Linux focused 65 passed. These results are historical and do not qualify the new head.Release disposition: NOT_READY
No admitted Finisher-specific independent eight-front production attestation, source/artifact identity sign-off, rollback operational proof, or authorized independent signed release verdict exists for this PR. Keep DRAFT and prevent deployment/merge until hosted CI, CodeQL, independent security review, real owner admission, production E2E, and sign-off are complete. Do not substitute a fixture or simulated success for genuine evidence.