Repository navigation
feat: sign release builds when certificate secrets are set - #25
Merged
Merged
Conversation
Developer ID and Authenticode secrets now reach electron-builder, with notarization when the Apple API key is present. A Flatpak manifest is included for a human Flathub submission, and the cask macOS floor matches the Electron binary. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packaging/flatpak/for a human Flathub submission. Flathub does not accept agent-opened pull requests.:monterey).Consequences
CSC_LINK,CSC_KEY_PASSWORD, and theAPPLE_API_*secrets exist. This machine only has an Apple Development certificate, which cannot notarize a public DMG.WIN_CSC_LINKandWIN_CSC_KEY_PASSWORD.Testing
bun run test:unit(34 passed)brew styleon the cask is cleanbrew audit --cask --new --onlinefails on signature (unsigned DMG) and GitHub notability, so nohomebrew-caskpull request was openedMade with Cursor