Repository navigation
fix(ci): checkout repo in release publish job - #21
Merged
Merged
Conversation
gh release edit fails with 'failed to run git: fatal: not a git repository' because the publish job has no actions/checkout step. This was masked while .deb packaging was broken; once that was fixed the publish job started running and exposed this latent bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutstep to thepublishjob in.github/workflows/release.yml.Why
After #20 unblocked Linux
.debpackaging, the release workflow started reaching thepublishjob, which runs:That command failed with:
ghneeds a git repo in the working directory to resolve the repository context. Thepublishjob had noactions/checkoutstep, so the runner's cwd wasn't a git repo.Consequences
None. The draft release and all artefacts from the previous run are already in place — this just lets the next release actually mark itself published.
Testing