Repository navigation
[opencode] chore: drop unused material-ui v4 deps from plausible plugin - #104
Merged
Merged
Conversation
The plugin source never imports @material-ui/core, icons, lab, @backstage/theme, @backstage/core-components or react-use - it only uses @backstage/core-plugin-api and react-helmet. Removes the dead declared deps instead of migrating them to @mui, which would just carry unused packages. Any remaining @material-ui v4 in the lockfile is Backstage core's own transitive requirement. Co-authored-by: opencode-agent[bot] <219766164+opencode-agent[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
@material-ui/core,@material-ui/icons,@material-ui/lab,@backstage/theme,@backstage/core-componentsandreact-usefromplugins/plausible's declared dependencies.Why
AGENTS.md mandates MUI v5 (
@mui/material) over@material-uiv4, and this was the last direct v4 declaration in the repo. While auditing for the migration, the plugin source turned out to import none of these packages at all -PlausibleAnalytics.tsxis areact-helmetwrapper over@backstage/core-plugin-apiand the test uses@backstage/test-utils/@backstage/core-app-api. Migrating to@mui/*would have replaced unused v4 packages with unused v5 packages. Dropping the dead declarations is the smaller, honest fix and removes drift rather than adding it.Note:
@material-uiv4 still appears inyarn.locktransitively via Backstage core packages (app-defaults,core-components,plugin-catalog, communitygithub-actions, ...). That is an upstream requirement of Backstage 1.55 and out of scope here.Validation
mise run lintpasses (all workspaces)mise run testpasses: 9 passed, 1 skippedyarn why @material-ui/coreshows only upstream Backstage consumers remain