Repository navigation
split 2226 unit 3b: view-local state fields, saveViewState, and the tests for them - #72
Open
easonLiangWorldedtech wants to merge 6 commits into
Open
easonLiangWorldedtech wants to merge 6 commits into
easonLiangWorldedtech wants to merge 6 commits into
Conversation
Carries the ClineProvider view-state state machine and the spec ranges this plan assigns to 3b, replayed from fb6d054958862e448b7a0afd836f5b0040a87e64 onto 76ab52f, plus the six lines of ViewStateRegistrationResult and its doc comment that unit 3a gave to 3b by ruling. The orphan doc note about the fields a view owns is carried here rather than left behind: 735dc22 deleted it from unit 3a because no declaration in that tree carried the name, and this unit adds the declaration, so the note sits above it as it does at line 292 of the donor provider blob.
Stryker still reports a surviving ConditionalExpression at src/core/webview/ClineProvider.ts line 1198 with replacement true, which makes any live provider count as the claimant regardless of which view state id it holds. Every earlier case used a second instance holding the same id, so none of them separated that behaviour from a guard that actually compares ids. This case gives the other instance a different id and requires a free id to adopt, which is exactly what the flipped comparison breaks. A companion case that re-affirmed an id the provider already held was tried and dropped: that path is a no-op reporting adopted false, so it cannot reach this mutant. No suppression and no Stryker disable were added.
Stryker still reports survivors at src/core/webview/ClineProvider.ts lines 1218 and 1220 and 1223. The 1218 row is a StringLiteral whose replacement is the empty string, so the assertion is on the delivery value the caller reads rather than on the adopted flag alone. The 1220 and 1223 rows are the entry test and the stored-claim test, both of which survive in the direction that skips the re-bind, leaving a pre-claim entry unbound under a key this view now owns; that case seeds an entry with no claim token and asserts the entry itself gains a string token, reading the store rather than the result. A third case for a bound entry was tried and dropped: registering an id whose entry already carries a stored claim token reports adopted false when no claim is presented, so the premise was wrong about the product and no assertion was bent to fit. No suppression and no Stryker disable were added.
Stryker reports a ConditionalExpression at src/core/webview/ClineProvider.ts line 1230 whose replacement false adopts a key a concurrent registration has just bound, and uncovered StringLiterals at lines 1235 and 1248 carrying the two refusal reasons. The concurrent case reads the entry once without a claim token, which sends the re-bind off, and once with a token, which is what a competing registration leaves behind, and requires the refusal to reach the caller together with the reason the code states at line 1235. The foreign claim case seeds an entry holding a token this launch did not present and asserts the stated reason at line 1248 rather than the adoption flag alone, because replacing the reason with an empty template keeps the refusal and drops the explanation. A first attempt at this commit edited the spec by string surgery and left it unparseable, prettier exit 2 with no commit made, so the file was restored from the HEAD blob and the two cases appended whole. No suppression and no Stryker disable were added.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-open body, unit 3b (fork PR 72), published on the fork; the upstream re-open follows the merge of 2414
Status of this document as published, recorded at 00:32:53Z on 2026-11-11: this is the published body of the re-opened unit 3b, not a skeleton. The hard rule about slots stands and is met, every slot that the draft left in square brackets was a measurement this lane had not yet taken at the rebased head, and each one is now filled from a reading named with its instrument, its timestamp and its base, never from memory. What has happened since the draft was written: the fork head 45da402 of branch vps2/2226-u3b-preview was pushed at 2026-11-11T00:26:10.284Z UTC, the sibling head ca2dc28, which is not an ancestor of this head: unit 3b and 2414 both branch from 735dc22, so 2414 is the branch that merges before this one in merge order and not a commit this head descends from, measured in the shared store at 2026-11-11T01:07:21.634Z UTC was read by git ls-remote at 2026-11-11T00:28:12.147Z UTC, and this body is one of six written by PATCH on 2026-11-11. Figures this lane has not measured stay described as unmeasured, which is why the mutation leg is reported as unrun at every head now on the fork and unread at a fork head, and why no unit of this chain is reported green.
Merge order and base
Merge order for the chain: 2411, then 2414, then 3b (fork PR 72), 4a (74), 4b (75), 4c (77), 4d (79), 4e (83). Each unit is re-based onto main and re-opened upstream on its own fork head after 2414 merges.
Base for this pull after the re-open: 45da402 as the head of the branch below, read by git ls-remote at 2026-11-11T00:31:48.734Z UTC. Class: 2414's head commit, the branch this fork branch was cut from (an upstream commit that is not main and not a fork branch of the upstream repo).
Today's published head is 45da402 and its published parent is ca2dc28, class: 2414's head commit, the branch this fork branch was cut from (an upstream commit that is not main and not a fork branch of the upstream repo). Those are the coordinates of the staging state, not of the re-open. Both shas read by git ls-remote at 2026-11-11T00:31:48.734Z UTC.
Chain reviewability for the whole chain, the axis this campaign chose for itself: measured at the amended 4e head c807c99 over merge base 18861b2, with main read by git ls-remote at 2026-11-11T00:28:12.147Z UTC as 53cb5b5, reading 1, the package-scoped figure the gate prices, gives 7 files, 531 changed executable lines and 151 selector ranges, extension 523 lines and 149 selectors and types 8 and 2, so the extension package is over the 500-line limit on the cumulative axis and that is what the exemption-or-consolidation question is about; the question goes once to maintainers on the tracking comment rather than six times into six bodies, and no pull in this chain carries a width breach against its own base, the largest unit axis being 8 lines and 5 selectors at unit 4a against caps of 500 lines and 400 mutants.
The clearing event for the owed rows, unchanged: the merge of 2414, then each unit re-based onto main and re-opened upstream on its own fork head. 1652 and 2226 are maintainer-side and nothing further is filed on them by this lane.
Hard rule on the slots: no square-bracket slot survives the POST. A slot is filled from the rebased head or the body is not published; an unfilled bracket reaching a maintainer is how a local artifact becomes a public placeholder.
Delta axis
Gate axis 1: the unit against its own merge base
Gate axis 2: the chain against main tip
Verification legs, each naming its interpreter
Legs measured at the rehearsed heads. Each leg below was invoked as the tool's own entry script under the interpreter C:\Program Files\nodejs\node.exe, node v25.9.0, from the package directory inside the rehearsal worktree C:\work\Zoo-Code-fork\wt-f0-1528-rehearse, whose node_modules, src\node_modules, packages\types\node_modules and webview-ui\node_modules are junctions to the same installs that served the published legs; npm and pnpm were not in the loop, so every row names the version read from the tool's own package.json, and vitest, prettier, tsc and eslint are separate executables run by that one interpreter.
Ruleset figures, quoted as the dated read
Killers arrive in the merged state
Fold match
Coordinates that move because of the owed patch
Rehearsal of the rebase (local rehearsal, no branch moved, no REST call)
Resolution of the unit 4e assertion conflict (ruled in round 44)
provider["pendingViewStateClaims"].get("view-a")).toBe("claim-a"). The row after the amendment, same two line numbers, at the amended spec blob f47e3b9ae1a8b863ae82bab831b0ac0af83e16e6: test("releases a disposed provider's queued claim without attempting delivery", async () => { ... expect(provider["pendingViewStateClaims"].get("view-a")).toBeUndefined(). The two expect assertions that guard against delivery, expect(attemptSpy).not.toHaveBeenCalled() and expect(postMessageSpy).not.toHaveBeenCalled(), are untouched, which is the point of amending the assertion rather than deleting the row.[], an empty manifest, exit 0, because the unit delta touches only a spec file, which the instrument excludes; against upstream main tip 18861b2 (base class: main tip, printed by git merge-base for that pair) it prices types 8 changed executable lines in 1 file with 2 selectors and extension 523 changed executable lines in 6 files with 149 selectors against the instrument cap MAX_CHANGED_LINES 500, and the instrument's own thrown sentence is unchanged: Error: extension has 523 changed executable lines (limit 500). Split the PR or obtain a maintainer-reviewed narrow exclusion. The unrepaired published 4e head prices extension 522 with 148 selectors on the same base, so 523 and 149 belong to a tree carrying the claim clear and this amendment leaves both figures unmoved; every priced figure here names the tree it was priced on. The pricing pass is recorded in .tmp-cr-audit/.tmp-t342-amendment-pricing.json, 7,686 bytes, sha256 017a4619b7f9f9ae6a0e12b31bed92e68845052455fab63496fd4505c7dcb867.Publication stamps to carry in the body
Update from the lane, recorded 2026-11-11T02:2xZ UTC, as a pull-level statement rather than a reply to any thread. This pull now sits at 8dc5818, moved from 45da402 by a push whose lease was pinned to the same run's read of refs/heads/vps2/2226-u3b-preview at that earlier value and which is proved by the post-push read-back reading the new head equal to the intended head rather than by its exit code. The move is one commit carrying only a test file, src/core/webview/tests/ClineProvider.view-state-claim-guard.spec.ts, 8044 bytes and 272 lines, blob 9c2a7365806a, six tests over the seven mutated rows in ClineProvider.ts lines 1157, 1179, 1186, 1191, 1198, 1200 and 1206, prettier and eslint with prune-suppressions and max-warnings 0 clean on it, the package type-check clean, and vitest on that file reporting 6 passed of 6. The width counter was re-run on trees after the commit rather than inherited: on the parent axis from 735dc22 correcting a transcription error, the published string was 39 characters because a digit was dropped rather than reordered and therefore fails the mutation instrument own rule that a commit sha must be a full 40 character value, so the parent axis base is this 40 character object to this head it reads extension 163 changed executable lines, identical to the figure measured before the commit, so the new spec moved no axis, and over the merge base 18861b2 this 3b tree alone reads extension 515 changed executable lines, which is above the 500 limit by 15 lines on the axis CI prices and is a different quantity from the 523 priced over the same base at the 4e chain head c807c99, that figure covering the whole chain rather than this unit, so nothing here should be read as a unit sitting under the cap. The pre-push hook was measured as git runs it in the worktree under the pre-push revision this branch itself carries, 1385 bytes sha256 719b2b28d50f, not the main checkout's 1427 bytes sha256 3d9be95e3ad5, with core.hooksPath .husky/_ so the generated shim chains to the tracked hook, and with one ref line on stdin naming this branch it exits 0 running check-types in 13 packages. Finally, and this is the fact a maintainer needs before reading anything above as a pipeline result: a read of the check-run set on this repository at the new head returns total_count 0 with an empty set, so a push to this fork produces no check runs at all, the six required contexts exist only on the upstream side, and this pull carries no CI of its own; what it offers is its tree plus the local measurements named here, and the mutation stage that prices these rows is advisory in the ruleset, which makes the width and mutant questions a maintainer conversation rather than a merge block.