Daily era5 and era5-land#174
Conversation
|
I think some help with the checks is required 😅 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
===========================================
+ Coverage 98.96% 100.00% +1.03%
===========================================
Files 13 13
Lines 579 598 +19
===========================================
+ Hits 573 598 +25
+ Misses 6 0 -6 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
We should drop Python 3.9 support as it is end of life since last year. That will solve the py3.9 job. Dropping python 3.9 can be done with:
- drop 3.9 in .github/workflows/test_and_build.yml
- in pyproject.toml set
requires-python = ">=3.10"and remove "Programming Language :: Python :: 3.9" line
I was able to run
# era5 2dvar
uv run era5cli daily --variables total_precipitation --startyear 2000 --months 11
# era5-land
uv run era5cli daily --variables 2m_temperature --startyear 2000 --months 11 |
I also noticed this when running era5Land daily:
Ah this might be due to me requesting land daily data that does not exist... |
sverhoeven
left a comment
There was a problem hiding this comment.
Let's get CI green before merging.
I missed another 3.9 mention in
Line 6 in 2777263
|
@sverhoeven isort and black are contradicting eachother, I am not sure what to do here professionally, I could use your advise! |
I am no longer using isort, black and flake8 in my projects I switched over to ruff for import sorting ( For example ruff is used in https://github.com/eWaterCycle/ewatercycle . eWatercycle uses strict ruff, for less strict see https://github.com/i-VRESSE/rocrate-action-recorder/blob/main/pyproject.toml#L89-L106 . |
|
I changed it to resemble ewatercycle as you said, I didnt know what this line does: |
|
@sverhoeven I am guessing I need to make more tests? ;) |
Indeed, we do not want to get less coverage than we had. |
|
note: still need to make new docs I guess... @sverhoeven Also the testing for uid is not needed I guess, but a nice addition. Also, thanks for helping me through all this! |
|
@sverhoeven I added the documentation in the right place, I hope I didnt miss anything. |
sverhoeven
left a comment
There was a problem hiding this comment.
Looking good, almost there.
Please update https://github.com/eWaterCycle/era5cli/blob/main/docs/general_development.md#running-formatters-and-linters and mention ruff instead others.
This PR does is worthy of a new minor release (2.1.0), which you can already prepare in this PR or make a new PR for it see https://github.com/eWaterCycle/era5cli/blob/daily-era5-land/docs/general_development.md#making-a-release
Hi era5cli team,
Adressing issue #172: I added functionality to download era5(-land) data to era5cli.
I added some basic tests, please let me know if more are needed!
I have not yet added to the documentation, if you approve of the change I will add documentation and then we can merge!
Mark Melotto