Repository navigation
SDSTOR-22908 craft: align docs with wiki and api.md - #187
Merged
Merged
Conversation
sbinmalek
force-pushed
the
SDSTOR-26113
branch
from
October 15, 2026 06:43
0b9dae0 to
bb14711
Compare
sbinmalek
marked this pull request as ready for review
October 15, 2026 06:43
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/v6.x #187 +/- ##
===========================================
Coverage ? 50.55%
===========================================
Files ? 19
Lines ? 1357
Branches ? 600
===========================================
Hits ? 686
Misses ? 271
Partials ? 400 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sbinmalek
commented
Oct 19, 2026
| **SyncRSCommitLSN:** | ||
| - RAFT entry carries `{rs_commit_lsn, client_token, empty_slots[]}` | ||
| - **Leader pre-resolution:** before proposing `N`, the leader resolves every unresolved slot ≤ `N`: fetch it from any holder, or record an `Empty` verdict on quorum-lacks evidence (leader counts itself; non-responders never count); it must not propose past an unresolved slot | ||
| - **Leader pre-resolution:** before proposing `N`, the leader resolves every unresolved slot ≤ `N`: fetch it from any holder, or record an `Empty` verdict on quorum-lacks evidence; it must not propose past an unresolved slot. Quorum-lacks evidence means a **majority of the replica set's data members** positively lack the slot: the leader counts itself, non-responders never count, and arbiters (skinny mode) are excluded, since they are voters but hold no data. With N=3 that is the leader plus one confirming peer; with N=5, the leader plus two. Fewer confirmations leave the slot unresolved |
sbinmalek
force-pushed
the
SDSTOR-26113
branch
from
October 19, 2026 16:21
bb14711 to
a92fb3f
Compare
Add Logout/InternalLogout to rpcs.md, fix the Login redirect contract, scope the Empty-verdict quorum to data members, and drop stale NubloxProto / all_zeros-flag / fetch_from_peer references. Co-Authored-By: Claude <noreply@anthropic.com>
sbinmalek
force-pushed
the
SDSTOR-26113
branch
from
October 19, 2026 16:23
a92fb3f to
180a847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Logout/InternalLogout to rpcs.md, fix the Login redirect contract, scope the Empty-verdict quorum to data members, and drop stale NubloxProto / all_zeros-flag / fetch_from_peer references.