Skip to content

Fix shutdown hang on a volume left DESTROYING - #185

Merged
nnastonen merged 1 commit into
eBay:dev/v6.xfrom
nnastonen:SDSTOR-26084_fix_shutdown_hang
Oct 15, 2026
Merged

nnastonen merged 1 commit into
eBay:dev/v6.xfrom
nnastonen:SDSTOR-26084_fix_shutdown_hang

Conversation

@nnastonen

Copy link
Copy Markdown
Contributor

HomeBlocks shutdown hangs forever when a volume remove backs off on outstanding IO

  • If remove_volume finds IO in flight, it marks the volume DESTROYING and leaves the destroy to the reaper.
  • Once shutdown starts, the reaper's remove_volume() is rejected. Shutdown waits for DESTROYING volumes, so it never completes.

SDSTOR-26084

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev/v6.x@38fbb11). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lib/homeblks_impl.cpp 0.00% 1 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             dev/v6.x     #185   +/-   ##
===========================================
  Coverage            ?   50.55%           
===========================================
  Files               ?       19           
  Lines               ?     1357           
  Branches            ?      600           
===========================================
  Hits                ?      686           
  Misses              ?      273           
  Partials            ?      398           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raakella1 raakella1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@nnastonen
nnastonen merged commit 76bb1e0 into eBay:dev/v6.x Oct 15, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants