chore: update e2b js to 2.24 and python to 2.23 - #273
Conversation
PR SummaryMedium Risk Overview Changes the Python code interpreter to stop using the base SDK’s shared transport for Jupyter requests and instead create a dedicated Reviewed by Cursor Bugbot for commit 875fb09. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05e2dd5d1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I had to change the package a little
jakubno
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5370210. Configure here.
The base e2b SDK's shared transport now defaults to http2=True. On the streaming /execute endpoint HTTP/2 multiplexing means a cancelled request only resets the H2 stream — the underlying TCP connection stays open and the server can't detect the client disconnect, so long-running executions can't be cancelled reliably. Use e2b's get_transport with http2=False for the Jupyter client to keep a 1:1 mapping between TCP connection and request.
02b3a4d to
2f903ac
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f903acd87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 participants
The transport in
e2bcore package now hashttp2=True. This is the key change. With HTTP/2, multiple requests are multiplexed over a single TCP connection. When a request is cancelled (e.g., the client streams disconnect), the server may not detect connection disconnect the same way as HTTP/1.1, because the TCP connection itself isn't closed — only the HTTP/2 stream is cancelled.