Use Node 24 for release job to get npm 11 - #259
Merged
Conversation
Works around npm's "Cannot find module 'promise-retry'" error when upgrading to npm 11.6 over the npm 10.x bundled with Node 22. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Node 24.15 ships with npm 11.12, which already satisfies the OIDC publish requirement. Avoids the broken npm self-install in Node 22's tool cache (npm/cli#8859, "Cannot find module 'promise-retry'") by skipping the upgrade step entirely. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
PR SummaryMedium Risk Overview Removes the explicit "Update npm" step, relying on the npm version bundled with Node 24 during releases. Reviewed by Cursor Bugbot for commit 34394ce. Bugbot is set up for automated code reviews on this repo. Configure here. |
tvi
approved these changes
Apr 24, 2026
jakubno
approved these changes
Apr 24, 2026
mishushakov
added a commit
that referenced
this pull request
Aug 6, 2026
Bump pnpm 9.15.9 -> 10.34.5 across packageManager fields, engines and all seven pnpm/action-setup steps. pnpm 10 blocks dependency lifecycle scripts by default, so esbuild is added to onlyBuiltDependencies to keep the JS build working. The lockfile is unchanged (v9.0 format is shared by pnpm 9 and 10). Set minimumReleaseAge to 4320 minutes (3 days) so newly published versions have time to be caught and unpublished before we install them, with `e2b` excluded since we control its releases. Renovate gets a matching minimumReleaseAge and exemption, otherwise it proposes versions pnpm then refuses to install. Move pnpm, Node and Bun versions into .tool-versions, alongside the Python and Poetry entries already wired up there. Node was hardcoded in seven places at three different versions; the release job keeps its explicit Node 24 pin, which is deliberate for npm 11 OIDC trusted publishing (#259). Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #258 didn't fix the release workflow — `--force` still crashed with `Cannot find module 'promise-retry'` (failed run) because the Node 22 tool cache's bundled npm is broken before any flag takes effect.
Switching the release job to Node 24.x (which ships with npm 11.12) lets us drop the "Update npm" step entirely while still satisfying the OIDC/provenance publish requirement.
Test plan
🤖 Generated with Claude Code