-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove SDK-side defaults from API request payloads #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,594
−352
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
1c4dc53
Remove SDK-side defaults from API request payloads
devin-ai-integration[bot] b92ce2b
Fix ruff formatting in test_api_defaults.py
devin-ai-integration[bot] 996c679
Keep SDK-side secure=true default for sandbox creation
devin-ai-integration[bot] ef24b64
Remove redundant API-default doc mentions
devin-ai-integration[bot] b984e34
fix(sdk): match JS and Python on malformed and null egress proxy input
mishushakov 6d991cb
Revert "fix(sdk): match JS and Python on malformed and null egress pr…
devin-ai-integration[bot] aa59e1f
Pin explicit 300s timeout in test sandbox fixtures
devin-ai-integration[bot] e4d7b95
Address review: add template build payload tests, mirror connect time…
devin-ai-integration[bot] a06670b
Drop SDK-side connect timeout and secure defaults
devin-ai-integration[bot] e9963a5
Remove client-side fork count validation per T-52
devin-ai-integration[bot] 7f20cda
Merge origin/main into devin/1787318715-remove-sdk-defaults
devin-ai-integration[bot] 947368f
Merge origin/main into devin/1787318715-remove-sdk-defaults
devin-ai-integration[bot] c5ed9b1
feat(sdk): create and connect sandboxes through the v2 API endpoints
devin-ai-integration[bot] 9a90eef
Merge origin/main into devin/1787318715-remove-sdk-defaults
devin-ai-integration[bot] 9055c26
Drop removed secure option from downstream packages and point client …
devin-ai-integration[bot] 31c28c0
Update template build body tests for API-owned cpu/memory defaults
devin-ai-integration[bot] 88e5b44
Drop removed secure option from sync secured-files tests
devin-ai-integration[bot] f345482
Keep deprecated secure option accepted and drop logsOffset preset
devin-ai-integration[bot] e875d62
Sync v2 sandbox timeout minimum from belt spec
devin-ai-integration[bot] 973a2da
Sync v2 sandbox timeout minimum (15s) from belt spec
devin-ai-integration[bot] 0ee39e4
Sync v2 sandbox timeout minimum (1s) from belt spec
devin-ai-integration[bot] e7306ec
chore(spec): bump runtime-ref to the exported v2 sandbox create/conne…
devin-ai-integration[bot] f611cef
Merge remote-tracking branch 'origin/main' into devin/1787318715-remo…
devin-ai-integration[bot] 11d377d
test(js-sdk): use setupMockApi in apiDefaults test so it runs in the …
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| 'e2b': minor | ||
| '@e2b/python-sdk': minor | ||
| --- | ||
|
|
||
| Remove SDK-side defaults from API request payloads so the API defaults apply when options are omitted. Sandbox create/fork/connect no longer preset a 5-minute timeout, fork no longer presets `count: 1`, create no longer presets `allow_internet_access`, pause no longer presets keeping memory, and template builds no longer preset CPU/memory. Explicitly provided values are still sent unchanged. | ||
|
|
||
| Sandbox create and connect now use the v2 API endpoints (`POST /v2/sandboxes`, `POST /v2/sandboxes/{id}/connect`), which default `timeout` to 5 minutes and always secure envd access. The `secure` option on `Sandbox.create` is deprecated: every sandbox is secured, so the option is still accepted but ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@e2b/desktop-python': minor | ||
| --- | ||
|
|
||
| Deprecate the `secure` option of `Sandbox.create` (still accepted, now ignored): every sandbox is created through the v2 API, which always secures envd access. `allow_internet_access` is no longer preset to `True`; when omitted, the API default applies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| 'e2b': patch | ||
| '@e2b/python-sdk': patch | ||
| --- | ||
|
|
||
| Remove client-side validation of the fork `count` argument. The API validates the requested fork count and rejects invalid values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.