Repository navigation
(closes #275) Fix Downgrade for Creating Schema and Dropdown in Same Op - #278
Merged
Merged
Conversation
ndamania00
added
the
semver:patch
ndamania00
changed the title
ndamania00
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when downgrading an operation that simultaneously creates a schema and dropdown in the same Op. Also some other small clean-ups and fixes
ArchiveDropdownorder to 19. It was previously the same order index as another operationArchiveDropdown. It previously didn't allow archiving a dropdown that was in use for a non-archived field. However, this is not the case on Benchling's side so no need for this check.Proof of upgrade -> downgrade -> reupgrade working
