Skip to content

resolve parent_link and entity_link bugs, tighten column validation - #277

Merged
ndamania00 merged 2 commits into
mainfrom
fix-parent-link-and-entity-link-bug
Nov 7, 2026
Merged

ndamania00 merged 2 commits into
mainfrom
fix-parent-link-and-entity-link-bug

Conversation

@ndamania00

@ndamania00 ndamania00 commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

This PR fixes 3 bugs.

  1. When parent_link goes from True -> False, it previously would lead to the Update operation setting to None, when it should be False.
  2. Liminal type ENTITY_LINK can have parent_link set on it
  3. When entity_link goes from something to None, it previously would skip this case. Now, it sets linkDefinition to None and ensures the type remains ANY_ENTITY_LINK_FIELD_DEFINITION if type is unchanged and remains ENTITY_LINK.

Added validation for when bool(parent_link and not entity_link). Tightened validation so it now raises an error if bool(parent_link and type != BenchlingFieldType.ENTITY_LINK)

This PR also moves schema properties docstring to __init__ so that on class hover, it shows up

@ndamania00 ndamania00 added type:bug Something isn't working semver:patch A backwards compatible bug fix (patch version bump) labels Nov 7, 2026
@ndamania00 ndamania00 changed the title fix parent_link and entity_link bugs resolve parent_link and entity_link bugs, tighten column validation Nov 7, 2026
@ndamania00
ndamania00 merged commit 5e77ec6 into main Nov 7, 2026
6 checks passed
@ndamania00
ndamania00 deleted the fix-parent-link-and-entity-link-bug branch November 7, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch A backwards compatible bug fix (patch version bump) type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant