Support C++23 - #624
Open
arcondello wants to merge 4 commits into
Open
Conversation
arcondello
force-pushed
the
c++23
branch
3 times, most recently
from
August 19, 2026 05:11
ee058d5 to
896b868
Compare
Specifically places where we have comments wishing for C++23
Member
Author
|
I'd like to sweep clang versions like we do gcc in CI, but I only see an unofficial clang docker. For posterity, search/claude tells me that our floor is likely clang17 (as roughly corresponding to gcc14). |
arcondello
marked this pull request as ready for review
August 19, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To take advantage of most C++23 features, we require GCC 14+. We can't go higher than 14 because we build
manylinux2_28wheels which use GCC 14.Closes #577
AI Generation Disclosure
I consulted Claude about the feasibility of using LLVM for Windows wheels because testing live in CI is a pain. And it was very helpful in diagnosing a bug that came from using
clang++rather thanclang-cl.