Keep the soak SSH session alive during cache drain - #159
Merged
Conversation
24 tasks
rmcdaniel
marked this pull request as ready for review
September 10, 2026 14:40
Member
Author
|
Reviewed the two-file diff: this only sets native SSH liveness options and tests the effective OpenSSH configuration. Provisioning credentials, host-key handling, cleanup, workload, memory thresholds and 310-second drain are unchanged. All public checks now pass, including PHP feature qualification and the real short polling/cache-drain smoke. Local focused tests: 24 passed. This does not validate the remote two-hour transport itself or resolve the workload timeouts in the daily-run review. No package, SDK, image or production deployment is needed. The next ordinary scheduled soak uses this repository script; no extra paid run is being triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The September 10 daily soak completed all 1,440 load samples, then its SSH connection failed with
Broken pipeduring the intentionally silent 310-second cache drain. That prevented the final sample and summary from being retained. The controller still deleted the disposable VM and verified that it was absent.Change
Use OpenSSH's built-in
ServerAliveInterval=30andServerAliveCountMax=6for the existing SSH transport. No custom heartbeat, retry coordinator, additional paid run, or change to the workload, host size, drain duration, or acceptance thresholds.The regression test invokes
ssh -Gusing the actual shell options, without a connection or provider credentials.Verification
bash -n scripts/perf/run-vultr-soak.shpassed.git diff --checkpassed.This only addresses report transport. The same run retained 575 validated workflow completions from 595 attempts, 20 client wait timeouts, and four readiness-probe timeouts. Those findings remain unresolved; this is not a passing endurance result.
Related: #137