Report persisted workflow deadlines as typed terminal timeouts - #55
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
September 6, 2026 07:54
This was referenced Sep 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54.
Maps canonical WorkflowTimedOut history to the exported WorkflowTimedOut SDK exception instead of returning None. Covers execution_timeout and run_timeout. The caller's built-in TimeoutError remains distinct; selected history and existing failure/cancellation/termination behavior are unchanged.
Validation on main fe4b059 plus the candidate:
This is a result-mapping correction, not a replay or codec change. Related PHP correction: durable-workflow/sdk-php#56. Rust already covers this terminal outcome.