Skip to content

Simplify certbot error messages #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Aug 12, 2026
+8 −2
Merged

Simplify certbot error messages #4133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/dstack/_internal/proxy/gateway/services/nginx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def run_certbot(cls, domain: str, acme: ACMESettings) -> None:

cmd = ["sudo", "timeout", "--kill-after", str(CERTBOT_2ND_TIMEOUT), str(CERTBOT_TIMEOUT)]
cmd += ["certbot", "certonly"]
cmd += ["--non-interactive", "--agree-tos", "--register-unsafely-without-email"]
cmd += ["--non-interactive", "--agree-tos", "--register-unsafely-without-email", "--quiet"]
cmd += ["--keep", "--nginx", "--domain", domain]

if acme.server:
Expand All @@ -283,7 +283,13 @@ def run_certbot(cls, domain: str, acme: ACMESettings) -> None:
" Make sure DNS records are configured for this gateway."
)
if r.returncode != 0:
raise ProxyError(f"Error obtaining {domain} TLS certificate:\n{r.stderr.decode()}")
msg = (
r.stderr.decode()
.lstrip("An unexpected error occurred:\n")
.strip()
.replace("\n", " ")
)
raise ProxyError(f"Error obtaining {domain} TLS certificate: {msg}")

@staticmethod
def certificate_exists(domain: str) -> bool:
Expand Down
Loading