Skip to content

PHP 8.4 deprecation warning in the password_policy contrib module - #348

Open
danrod96-new wants to merge 1 commit into
drupalwxt:6.3.xfrom
danrod96-new:password-policy-php-deprecation-warning-6.3
Open

danrod96-new wants to merge 1 commit into
drupalwxt:6.3.xfrom
danrod96-new:password-policy-php-deprecation-warning-6.3

Conversation

@danrod96-new

Copy link
Copy Markdown

When running drush migrate:import --group wxt --tag 'Core' in a WxT ddev instance running PHP 8.4, I notice this deprecation warning:

PHP Deprecated:  Drupal\password_policy\Plugin\migrate\process\PolicyConfiguration::create(): Implicitly marking parameter $migration as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/html/modules/contrib/password_policy/src/Plugin/migrate/process/PolicyConfiguration.php on line 59

Deprecated: Drupal\password_policy\Plugin\migrate\process\PolicyConfiguration::create(): Implicitly marking parameter $migration as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/html/modules/contrib/password_policy/src/Plugin/migrate/process/PolicyConfiguration.php on line 59
 [notice] Processed 13 items (13 created, 0 updated, 0 failed, 0 ignored) - done with 'wxt_file'
 [notice] Processed 13 items (13 created, 0 updated, 0 failed, 0 ignored) - done with 'wxt_media'
 [notice] Processed 3 items (3 created, 0 updated, 0 failed, 0 ignored) - done with 'wxt_media_slideshow'
 [notice] Processed 2 items (2 created, 0 updated, 0 failed, 0 ignored) - done with 'wxt_node_page'
Steps to reproduce
- Set up a local instance, make sure it runs PHP 8.4
- Install WxT by following the instructions
- Run drush migrate:import --group wxt --tag 'Core', you should get the PHP deprecation warning.

Proposed resolution
There is already a patch to fix this.

Remaining tasks

  • Create a PR in the github repo, and perhaps a MR here.

User interface changes
N/A

API changes
N/A

Data model changes
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant