Repository navigation
Fix OVHcloud record creation for DNS-01 and Dynamic DNS - #458
Merged
Merged
Conversation
POST /domain/zone/{zone}/record returns the new domain.zone.Record, not
a bare ID, so DNS-01 challenges and Dynamic DNS creates failed with
"cannot unmarshal object into Go value of type int64".
Fixes #450
This was referenced Oct 14, 2026
Merged
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #450.
OVHcloud's
POST /domain/zone/{zone}/recordreturns the createddomain.zone.Recordobject ({"id":…,"zone":…,"fieldType":…,"subDomain":…,"target":…,"ttl":…}), not a bare record ID. Both callers decoded intoint64:ovhProvider.Present(ACME DNS-01) — fails every public TLS issuance/renewal withdecode OVHcloud response: json: cannot unmarshal object into Go value of type int64.ovhProvider.EnsureRecord(Dynamic DNS) — same failure whenever the record doesn't exist yet and has to be created.Both now decode into a small
ovhCreatedRecord{ID}struct;Presentkeeps the ID for cleanup. This matches how lego's OVH provider reads the same response.Tests
TestOVHProviderRefreshesAfterCreateAndCleanupmocked the response as42, which is why this slipped through; it now uses the real object shape.TestOVHEnsureRecordCreatesMissingRecordcovers the Dynamic DNS create path.mage verifygreen.No UI changes.