Fixed docs workflows building the v2 binary from the removed '.vortex/installer' path. - #2861
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2861 +/- ##
==========================================
- Coverage 86.91% 86.49% -0.43%
==========================================
Files 100 93 -7
Lines 4830 4671 -159
Branches 47 3 -44
==========================================
- Hits 4198 4040 -158
+ Misses 632 631 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a69881132973464a3b60bfc--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
Summary
The
Vortex - Test docsworkflow onmainfailed at the "Build and publish v2 installer" step withInvalid working directory specified, vortex-v2/.vortex/installer does not exist.The2.xbranch renamed.vortex/installerto.vortex/cli, replaced thebox.jsonreplacement tokenvortex-installer-versionwithvortex-cli-version, and now builds.build/vortex.pharinstead ofbuild/installer.phar. Bothvortex-test-docs.yml(the failing workflow) andvortex-release.ymlbuild the other major's binary by checking out the2.xbranch, and both still referenced the old.vortex/installerlayout, sovortex-release.ymlcarried the same defect and would have broken the next release. This updates the other-major build leg in both workflows to the current2.xlayout, renames the affected step labels from "installer" to "binary"/"artifact" wording since v2 ships a CLI rather than an installer, and switches the docs job's copy step to a*.pharglob since the v2 artifact now containsvortex.pharinstead ofinstaller.phar.Changes
.github/workflows/vortex-test-docs.yml: build the other major's binary in.vortex/cliinstead of.vortex/installer, sed thevortex-cli-versionbox.json token instead ofvortex-installer-version, copy.build/vortex.pharinstead ofbuild/installer.phar, and renamed the step to "Build and publish v${{ env.OTHER_MAJOR }} binary"..github/workflows/vortex-release.yml: the same working-directory, box.json token, and PHAR path fixes for the "Build v${{ env.OTHER_MAJOR }} binary" step, plus a*.pharglob in the docs job's "Copy binaries to docs" step so it matches whichever PHAR name each major's artifact actually contains, since the artifact is nowvortex.pharfor v2 rather thaninstaller.phar.vortex-installer-vN) are left unchanged - they are internal identifiers consumed within the same workflow run, and2.xuses the same names.Verification
actionlintpasses on both changed files. The fixed step is gated onhead_branch == 'main', so this PR's own CI cannot exercise it - the failure only reproduces on amaindocs run. To compensate, the exact CI sequence (composer install, thensedof thevortex-cli-versiontoken inbox.json, thencomposer build) was run locally against the real2.x.vortex/clitree. It produced.build/vortex.phar, and./.build/vortex.phar --versionprintedVortex CLI 2.x-dev, confirming the new path, token, and PHAR name all line up with what2.xactually ships.Before / After